Fix SuSE connect service, if data is missing (Branch 2.4.0) #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File "/omd/sites/nagios/share/check_mk/checks/suseconnect", line 77, in check_suseconnect state, infotext = 0, "Subscription: %(subscription_status)s" % specs KeyError: subscription_status Signed-off-by: Sven Rueß <github@sven-ruess.de>
Signed-off-by: Sven Rueß <github@sven-ruess.de>
CheckmkCI
pushed a commit
that referenced
this pull request
Jul 23, 2025
…ilable When using the suseconnect plugin, a situation could arise where subscription status is not available. This werk implements a more graceful approach and avoids crashes when no subscription status is abailable. Signed-off-by: Sven Rueß <github@sven-ruess.de> Closes: #824 Change-Id: I0a0bc8e6f6de4b0fc95a0ee45d74c900c94e7d0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General information
Customer is using CEE 2.3.0p30 and check crashes on SLES 15.6 systems.
Customer will update to 2.4.0p2 soon. So it should be updated, too.
Bug reports
suseconnect is used on SLES 15.6 and should show state. Check crashes with information
File "/omd/sites/nagios/share/check_mk/checks/suseconnect", line 77, in check_suseconnect
state, infotext = 0, "Subscription: %(subscription_status)s" % specs
KeyError: subscription_status
Proposed changes
Check was adapted to work as expected. Check was introduced for needed data.
Output has changed, so it makes sense to adapt the check.
Customer is using this version with any issues.